Adding LTO options #692
Draft
Adding LTO options #692
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quic-akaryaki
force-pushed
the
lto-options-2
branch
from
2089409 to
9b83e52
Compare
quic-seaswara
approved these changes
Jan 6, 2026
quic-akaryaki
force-pushed
the
lto-options-2
branch
3 times, most recently
from
0e3fe1c to
5f1c4cc
Compare
quic-akaryaki
force-pushed
the
lto-options-2
branch
2 times, most recently
from
2ddb004 to
efde665
Compare
ObjectLinker::doLto() had convoluted flow, duplicated pieces of code in different branches, etc. Simplify and clarify it. There is no functional change, except when both `lto-asm-file` and `lto-output-file` specified, on Hexagon only, a misleading message about using the asm file is not printed. When `lto-output-file`, the assembly inputs are ignored, this did not change, and the message was incorrect. Signed-off-by: Alexey Karyakin <akaryaki@qti.qualcomm.com>
quic-akaryaki
force-pushed
the
lto-options-2
branch
from
efde665 to
16da071
Compare
quic-akaryaki
force-pushed
the
lto-options-2
branch
from
d0396b3 to
6511b66
Compare
Signed-off-by: Alexey Karyakin <akaryaki@qti.qualcomm.com>
Signed-off-by: Alexey Karyakin <akaryaki@qti.qualcomm.com>
These options have aliases: --plugin-opt=cs-profile-generate --plugin-opt=cs-profile-path= Signed-off-by: Alexey Karyakin <akaryaki@qti.qualcomm.com>
Signed-off-by: Alexey Karyakin <akaryaki@qti.qualcomm.com>
Signed-off-by: Alexey Karyakin <akaryaki@qti.qualcomm.com>
Signed-off-by: Alexey Karyakin <akaryaki@qti.qualcomm.com>
quic-akaryaki
force-pushed
the
lto-options-2
branch
from
6511b66 to
c03a043
Compare
--lto-obj-path will work differently than in lld. In lld, it creates copies of LTO output files, which means with `-save-temps` each object file will be written twice. Instead, we will redirect output files to the location specified by `--lto-obj-path`, which means these files will not be written to the `-save-temps` location if it is specified. Signed-off-by: Alexey Karyakin <akaryaki@qti.qualcomm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.